feat(query): cherry-pick Add mechanism to have a limit on number of pending queries #7990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing up the cherry-pick.
danielmai
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
Note: This cherry-pick doesn't include the superflag changes that came in before max-pending-queries was introduced.
This PR adds the flag --max_pending_queries back to v20.11.
This PR also includes the dgraph increment --conc flag addition that was a part of #7603.
This is needed for ESPLUS-361.
Reviewed 1 of 3 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to avoid blowing up the number of goroutines handling queries, if the user bombards Dgraph with lots of concurrent / asynchronous requests.
Cherry pick from #7603
This change is