Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal predicate for string namespaces #9282

Merged
merged 1 commit into from
Jan 30, 2025
Merged

add internal predicate for string namespaces #9282

merged 1 commit into from
Jan 30, 2025

Conversation

mangalaman93
Copy link
Member

@mangalaman93 mangalaman93 commented Jan 21, 2025 •
edited
Loading

This PR adds two internal predicates and one internal type needed for supporting namespaces with string names. We are creating a separate PR so that we can take this PR as model PR for adding more internal predicate in future.

@mangalaman93 mangalaman93 requested a review from a team as a code owner January 21, 2025 05:41
@github-actions github-actions bot added area/schema Issues related to the schema language and capabilities. area/core internal mechanisms go Pull requests that update Go code labels Jan 21, 2025
@trunk-io Trunk.io
Copy link

trunk-io bot commented Jan 21, 2025 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

@github-actions github-actions bot added area/testing Testing related issues area/enterprise Related to proprietary features area/integrations Related to integrations with other projects. area/enterprise/acl Related to Access Control Lists labels Jan 21, 2025
@mangalaman93 mangalaman93 force-pushed the aman/internal branch 2 times, most recently from ffed294 to 753bc7b Compare January 21, 2025 11:01
ryanfoxtyler
ryanfoxtyler reviewed Jan 21, 2025
View reviewed changes
@mangalaman93 mangalaman93 force-pushed the aman/internal branch 3 times, most recently from 608e9bc to 5d156a5 Compare January 27, 2025 09:47
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Jan 27, 2025
@mangalaman93 mangalaman93 enabled auto-merge (squash) January 27, 2025 09:49
@mangalaman93 mangalaman93 force-pushed the aman/internal branch 2 times, most recently from 1704305 to 4b0b1c2 Compare January 27, 2025 16:46
@mangalaman93 mangalaman93 disabled auto-merge January 27, 2025 17:10
@mangalaman93 mangalaman93 changed the title add internal predicate for string namespaces [DO NOT MERGE] add internal predicate for string namespaces Jan 27, 2025
@mangalaman93 mangalaman93 changed the title [DO NOT MERGE] add internal predicate for string namespaces add internal predicate for string namespaces Jan 30, 2025
@mangalaman93 mangalaman93 enabled auto-merge (squash) January 30, 2025 09:56
@mangalaman93 mangalaman93 disabled auto-merge January 30, 2025 09:58
@mangalaman93 mangalaman93 merged commit d8c8e9a into main Jan 30, 2025
14 checks passed
@mangalaman93 mangalaman93 deleted the aman/internal branch January 30, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

@ryanfoxtyler ryanfoxtyler Awaiting requested review from ryanfoxtyler

@shivaji-kharse shivaji-kharse Awaiting requested review from shivaji-kharse

Assignees
No one assigned
Labels
area/core internal mechanisms area/enterprise/acl Related to Access Control Lists area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/integrations Related to integrations with other projects. area/schema Issues related to the schema language and capabilities. area/testing Testing related issues go Pull requests that update Go code
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mangalaman93 @harshil-goel @ryanfoxtyler @shivaji-kharse