Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/1519 #1570

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Issues/1519 #1570

merged 4 commits into from
Aug 17, 2022

Conversation

Raj6939
Copy link
Collaborator

@Raj6939 Raj6939 commented Aug 17, 2022

  • HfButtons.vue component added in components/elements folder.
  • It is used at Events.vue and participants.vue page.
  • added validation for ExportAll button and Lottery

color: var(--button-text-color);
border: 0;
}
.theme {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the use of this class?

@@ -0,0 +1,59 @@
<template>
<!-- <button class="btn btn-primary button-theme" :style="buttonThemeCss"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the hardcoding

@click="clickBtn"
>
{{name}}</button> -->
<div :class="styleClass ? `${styleClass}` : 'btn btn-primary button-theme'" :style="buttonThemeCss"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here will buttonThemeCss not override value in :class ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will not override

Copy link
Collaborator

@Vishwas1 Vishwas1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pleas fix all this

type: String,
require: false
},
styleClass:{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change the name of this prop to customClass

@Vishwas1 Vishwas1 merged commit e1237ad into develop Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants