HfButtons component is used in all other components #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vishwas1
reviewed
Aug 18, 2022
| </button> | ||
| </button> --> | ||
| <hf-buttons | ||
| name="Add" |
There was a problem hiding this comment.
Why only "Add" ? what about "Update" case?
This condition
{{ eventActionList.includes(selected) ? "Update" : "Add" }}
Vishwas1
reviewed
Aug 18, 2022
| <button @click="handleEventActionAdd()" class="btn button-theme slight-left-margin-5" :style="buttonThemeCss" type="button"> {{eventActionList.includes(selected) ? "Cancel" : "Add"}}</button> | ||
| <!-- <button @click="handleEventActionAdd()" class="btn button-theme slight-left-margin-5" :style="buttonThemeCss" type="button"> {{eventActionList.includes(selected) ? "Cancel" : "Add"}}</button> --> | ||
| <hf-buttons | ||
| name="Add" |
There was a problem hiding this comment.
Why only Add case, what happened to Cancel?
Vishwas1
reviewed
Aug 18, 2022
| class="btn btn-success btn-sm" | ||
| > | ||
| Active | ||
| ACTIVE |
Vishwas1
reviewed
Aug 18, 2022
src/views/admin/TeamMate.vue
Outdated
| @@ -91,21 +103,25 @@ | |||
| <td v-if="isAdmin(row.email)"> | |||
| <button | |||
There was a problem hiding this comment.
Why this button is not hf-button?
Vishwas1
reviewed
Aug 18, 2022
src/views/admin/TeamMate.vue
Outdated
| >Switch | ||
| </button> --> | ||
| <hf-buttons | ||
| name="SWITCH" |
There was a problem hiding this comment.
Why have you captiilize the button name ?
Vishwas1
requested changes
Aug 18, 2022
…nt and remove teammate button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HfButtonscomponent is used in all components.