Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release with py37 #34

Merged
merged 13 commits into from
Oct 27, 2018
Merged

Release with py37 #34

merged 13 commits into from
Oct 27, 2018

Conversation

ericpre
Copy link
Member

@ericpre ericpre commented Oct 23, 2018

Same as #33 but with python 3.7.

@ericpre ericpre mentioned this pull request Oct 23, 2018
2 tasks
@francisco-dlp
Copy link
Member

Since the new WP version contains JupyterLab, wouldn't it be good to add a Jupyter Lab entry in the Start Menu alongside the current Notebook and Console entries?

@ericpre
Copy link
Member Author

ericpre commented Oct 23, 2018

Yes, it would be good, but at the same time, we need to check that the matplotlib backend are working properly and also add the corresponding documentation.
I think we need to release a bundle quickly first and then work on jupyterlab.

@ericpre
Copy link
Member Author

ericpre commented Oct 23, 2018

I may have been pessimistic and it seems that the jupyter lab is working out of the box and %matplotlib widget to get the notebook backend is working fine. I will give a go.

@ericpre
Copy link
Member Author

ericpre commented Oct 24, 2018

For the last build with the shortcut for jupyter lab in the start menu and the context menu: https://ci.appveyor.com/project/ericpre/hyperspy-bundle/builds/19764021

…e to warn user to use an installation path with a length shorter than 35 characters.
@ericpre ericpre force-pushed the release_with_py37 branch 3 times, most recently from 217ade7 to 4ea8cd6 Compare October 25, 2018 17:19
@ericpre
Copy link
Member Author

ericpre commented Oct 26, 2018

I think this is all good now: #23 is fixed by preventing using a installation path too long.

https://ci.appveyor.com/project/ericpre/hyperspy-bundle/builds/19804008

@ericpre
Copy link
Member Author

ericpre commented Oct 26, 2018

I have tested the installation on windows 7 with the different installation mode and it works as expected. @francisco-dlp, could you finish the review and merge this and then we make the release from this repository?

@francisco-dlp
Copy link
Member

LGTM

@ericpre ericpre merged commit b442c93 into hyperspy:master Oct 27, 2018
@ericpre ericpre deleted the release_with_py37 branch March 30, 2019 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HyperSpy Bundle 2018.09.04: HyperSpyUI is not opening Build with Winpython 1.10 (2018-01): long path issue
2 participants