-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release with py37 #34
Conversation
Since the new WP version contains JupyterLab, wouldn't it be good to add a Jupyter Lab entry in the Start Menu alongside the current Notebook and Console entries? |
Yes, it would be good, but at the same time, we need to check that the matplotlib backend are working properly and also add the corresponding documentation. |
I may have been pessimistic and it seems that the jupyter lab is working out of the box and |
For the last build with the shortcut for jupyter lab in the start menu and the context menu: https://ci.appveyor.com/project/ericpre/hyperspy-bundle/builds/19764021 |
…h other convention.
…e to warn user to use an installation path with a length shorter than 35 characters.
217ade7
to
4ea8cd6
Compare
4ea8cd6
to
89b4dc8
Compare
I think this is all good now: #23 is fixed by preventing using a installation path too long. https://ci.appveyor.com/project/ericpre/hyperspy-bundle/builds/19804008 |
I have tested the installation on windows 7 with the different installation mode and it works as expected. @francisco-dlp, could you finish the review and merge this and then we make the release from this repository? |
LGTM |
Same as #33 but with python 3.7.