Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consume URL_PATH and evaluate according for span exclusion #451

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

sanket-mundra
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

Copy link
Contributor

@skjindal93 skjindal93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This comment has been minimized.

Copy link

codecov bot commented Feb 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed7b189) 79.56% compared to head (739a8bd) 79.59%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #451      +/-   ##
============================================
+ Coverage     79.56%   79.59%   +0.02%     
- Complexity     1428     1431       +3     
============================================
  Files           130      130              
  Lines          5692     5700       +8     
  Branches        533      533              
============================================
+ Hits           4529     4537       +8     
  Misses          911      911              
  Partials        252      252              
Flag Coverage Δ
unit 79.59% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanket-mundra sanket-mundra merged commit 7610898 into main Feb 14, 2024
11 checks passed
@sanket-mundra sanket-mundra deleted the sanket/useUrlPathInExclusionRules branch February 14, 2024 16:19
Copy link

Unit Test Results

  79 files  ±0    79 suites  ±0   1m 5s ⏱️ -3s
421 tests +1  421 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 7610898. ± Comparison against base commit ed7b189.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants