Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] How to trigger Tooltips in settings #692

Closed
wxharry opened this issue Jun 6, 2023 · 4 comments · Fixed by #694
Closed

[Improvement] How to trigger Tooltips in settings #692

wxharry opened this issue Jun 6, 2023 · 4 comments · Fixed by #694
Assignees
@Vlad116
Labels
good first issue Good for newcomers

Comments

@wxharry
Copy link
Collaborator

wxharry commented Jun 6, 2023

Description

Currently, the tooltips in the settings are triggered directly by hovering on the title container. IMO, it is no a big problem but it would be more intuitive if we could trigger the tooltips by adding a customize icon like this demo. Or, if the tooltips is unnecessary, we could consider removing it.

image
@menbotics menbotics bot added the kind/question Category issues related to questions or problems label Jun 6, 2023
@wxharry wxharry added good first issue Good for newcomers and removed kind/question Category issues related to questions or problems labels Jun 6, 2023
@stealth-bombeer
Copy link
Contributor

stealth-bombeer commented Jun 7, 2023 •
edited
Loading

We can create a toggle state in options.tsx, offcourse switch can be positioned at correct place and if required we can position the tooltip to the right-end of the stack-item for readability purpose

Options.mp4

Does this make sense ?

@Vlad116
Copy link
Contributor

Vlad116 commented Jun 7, 2023 •
edited
Loading

Wouldn't it be better to make tooltips on the question icon as @wxharry described. Something similar to what is shown in the screenshot (only with a more appropriate gray/white icon). I think this is the best solution in this case, many projects use this ux pattern in their applications and it will be intuitive to the user. Also, if you need it, I could add the ability to turn off tooltips (by switching the checkbox to the main plugin settings), but I think this is not really necessary if it only appears on hover over the icon

PR
If this option suits you, I will publish the PR today

@Vlad116

This comment was marked as resolved.

Sign in to view
Vlad116 added a commit to Vlad116/hypertrons-crx that referenced this issue Jun 7, 2023
@Vlad116
feat: add isTooltipEnabled state and stackStyleOptions const (hypertr…
16e957e 
…ons#692), ♻️
Vlad116 added a commit to Vlad116/hypertrons-crx that referenced this issue Jun 7, 2023
@Vlad116
feat: change cursor css prop to 'help' (hypertrons#692), 💄
3df9d11
@Vlad116 Vlad116 mentioned this issue Jun 7, 2023
Merged
10 tasks
@Vlad116
Copy link
Contributor

Vlad116 commented Jun 7, 2023

I have posted the PR and am waiting for edits or acceptance as you will have time to look at it @wxharry

Vlad116 added a commit to Vlad116/hypertrons-crx that referenced this issue Jun 8, 2023
@Vlad116
feat: remove Toggle button and move TooltipTrigger to /components (hy…
d3db459 
…pertrons#692), ♻️
Vlad116 added a commit to Vlad116/hypertrons-crx that referenced this issue Jun 8, 2023
@Vlad116
feat: fix TooltipTrigger styles (hypertrons#692), ♻️ 💄
dc8df59
@tyn1998 tyn1998 added this to HyperCRX Jun 8, 2023
Vlad116 added a commit to Vlad116/hypertrons-crx that referenced this issue Jun 15, 2023
@Vlad116
feat: fix defaultStyle for tooltip (hypertrons#692) 💄
e7fba0d
@menbotics menbotics bot closed this as completed in #694 Jun 28, 2023
menbotics bot pushed a commit that referenced this issue Jun 28, 2023
@Vlad116
feat: add tooltip trigger (#694)
a0764e3 
* feat: add switchable TooltipTrigger to settings page, 💄

* feat: add isTooltipEnabled state and stackStyleOptions const (#692), ♻️

* feat: change cursor css prop to 'help' (#692), 💄

* feat: remove Toggle button and move TooltipTrigger to /components (#692), ♻️

* feat: fix TooltipTrigger styles (#692), ♻️ 💄

* feat: fix defaultStyle for tooltip (#692) 💄

* feat: change cursor to 'default' on tooltip icon 💄
@github-project-automation github-project-automation bot moved this to Done in HyperCRX Jun 28, 2023
wxharry pushed a commit to wxharry/hypertrons-crx that referenced this issue Jul 17, 2023
@Vlad116 @wxharry
feat: add tooltip trigger (hypertrons#694)
07d7f99 
* feat: add switchable TooltipTrigger to settings page, 💄

* feat: add isTooltipEnabled state and stackStyleOptions const (hypertrons#692), ♻️

* feat: change cursor css prop to 'help' (hypertrons#692), 💄

* feat: remove Toggle button and move TooltipTrigger to /components (hypertrons#692), ♻️

* feat: fix TooltipTrigger styles (hypertrons#692), ♻️ 💄

* feat: fix defaultStyle for tooltip (hypertrons#692) 💄

* feat: change cursor to 'default' on tooltip icon 💄
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Vlad116 Vlad116

Labels
good first issue Good for newcomers
Projects
HyperCRX
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add tooltip trigger Vlad116/hypertrons-crx
3 participants
@Vlad116 @wxharry @stealth-bombeer