feat: show more data (in an embeded way) #455

tyn1998 · 2022-09-13T09:44:15Z

Brief Information

This pull request is in the type of:

bug fixing
new feature
others

Related issues:

resolve [Feature] Add more data for hypercrx #395
resolve [Feature] embeded view for star and fork (s,f) #432

Details

This illustration shows what we want to achieve:

Subtasks:

Checklist

I have read the CONTRIBUTING doc
I have signed the CLA

Others

tyn1998 · 2022-09-13T09:47:54Z

react-tooltip helps to implement the feature that when users hovering on certain elements there will be tooltips showing up and presenting anything we want.

tyn1998 · 2022-09-17T09:07:32Z

embeded views for star and fork come out:

light theme:

dark theme:

tyn1998 · 2022-09-17T14:05:07Z

Hi, @frank-zsy, I have some confusion about the data:

The json file:

I know the number of fork event is not equal to the number of fork, but how to explain the numbers show in the screenshot above? Why there is a huge gap?

Are unfork events counted into fork events?

frank-zsy · 2022-09-17T14:16:53Z

So cool!!

frank-zsy · 2022-09-17T14:23:14Z

@tyn1998 I think the data is not right, I will check it.

frank-zsy · 2022-09-17T14:31:29Z

I see, I put the data in wrong key, right now, the data in f is actually star count, in s is participants and in p is fork count. You can still use these keys and I will fix the data.

frank-zsy · 2022-09-17T14:32:14Z

And I think line chart can be used instead of bar chart which is more common in fork and star trending.

frank-zsy · 2022-09-17T14:36:23Z

If you are going to use hover to trigger the charts, please make sure that the mouse cursor can easily enter the chart and keep the charts showing so users can dive into the data. This may involve enlarge the detection fields of each charts.

I am not sure how to implement it but I think I expressed what I want.

tyn1998 · 2022-09-17T14:40:02Z

I see, I put the data in wrong key, right now, the data in f is actually star count, in s is participants and in p is fork count. You can still use these keys and I will fix the data.

Hah~got it.

And I think line chart can be used instead of bar chart which is more common in fork and star trending.

emm, the value of each month represents increment (i.e. 300 fork events ≈ 300 new fork), right? I considered line chart first but turned to bar chart since I thought "trending" required total number rather icrement number. But I can add a line to existing bars so we can present them all in one chart.

If you are going to use hover to trigger the charts, please make sure that the mouse cursor can easily enter the chart and keep the charts showing so users can dive into the data. This may involve enlarge the detection fields of each charts.

Sure, I have considered this. The hover-triggered box can be entered.

frank-zsy · 2022-09-17T16:02:23Z

The data update process should be completed by tomorrow morning and the data will be updated to 2022.8

tyn1998 · 2022-10-01T02:43:32Z

And I think line chart can be used instead of bar chart which is more common in fork and star trending.

Hi @frank-zsy, this is how a line chart looks like:

and its bar chart counterpart:

or a combination of both:

Which way do you prefer? I'm ok with all of them but mildly incline to the combination chart :) How about you guys? @will-ww @wxharry

BTW, if we adopt line charts, I need to insert "zero" data for those months without a single event because of:

frank-zsy · 2022-10-01T04:40:22Z

I think combination version is better, but what I like is that use bar chart to show the increase value of each month and use line chart to show the accumulate value of all history.

tyn1998 · 2022-10-01T04:43:46Z

Ok, I will implement it and update my progress here~

frank-zsy · 2022-10-01T05:11:31Z

But there is a problem that the accumulate value is not accurate since the data is from log events rather than API. So the users may feel quite confused and need to explain the difference. So we need to decide whether to add the accumulate line chart since it may cause extra cost of explanation.

* refactor: remove antv * refactor: remove all `graphType` or `GraphType` from codebase Co-authored-by: Lam Tang <tangyenan@gmail.com>

tyn1998 · 2022-10-03T05:29:16Z

For those months with 0 event, I insert zero data to make the line chart complete:

tyn1998 · 2022-10-03T14:24:27Z

embeded view for issue details:

tyn1998 · 2022-10-03T15:40:25Z

embeded view for PR details:

tyn1998 · 2022-10-03T16:00:24Z

tooltip format: not show day since the minimal is month

tyn1998 · 2022-10-04T15:16:00Z

tyn1998 · 2022-10-04T17:07:41Z

Finish basic version:

add-more-data.mov-8mb.mp4

wxharry · 2022-10-04T20:06:59Z

The injections look perfect! Really appreciate your work these days! The interactions are smooth and I don't have any sense of being interrupted.
We still need a uniform title for these charts though. Whether to use plural form or not. And the nanme in the legends might be oversimplified. Maybe we could compose a detailed explanation and refer to that document some day.

Again. Really appreciate your work Lam!

tyn1998 · 2022-10-05T01:41:37Z

@wxharry Thank your for yor appreciation!

We still need a uniform title for these charts though. Whether to use plural form or not.

Agree. Actually I tried, but it was so hard for me to decide on the use of plural forms. Could you help? Another limitation is that Echarts doesn't provide an option to center the title text so if users want to center the title text they should adjust left, top, etc. pixel by pixel, which is time consuming! Due to this, I tried to make the titles as long as the width of the charts to avoid trivial tuning, which might make the titles a little difficult to understand.

And the nanme in the legends might be oversimplified.

Agree. But they cannot be long since the width of the chart is limited. Docs are good and some hover-to-show features also make sense (support in future).

wxharry · 2022-10-05T14:53:05Z

Agree. Actually I tried, but it was so hard for me to decide on the use of plural forms. Could you help?

IMO, using plural form for all titiles is fine.

But they cannot be long since the width of the chart is limited.

Maybe use one word for each legend? Since we have a detailed title, it would be easy for users to understand what that is.

wxharry · 2022-10-05T17:34:17Z

Also, I noticed that there is a code frequency section in insight tab, which looks similiar to one of our graphs. Are these the same?

tyn1998 · 2022-10-06T01:16:46Z

Not the same. Our data only count code line changes after PR merge, while the GitHub counterpart might also include code line changes made by direct push.

chore: modify chart titles and legends

wxharry

LGTM

tyn1998

LGTM.

Hi @wxharry, please review and approve :)

wxharry · 2022-10-06T14:21:07Z

/approve

feat: show tooltips when mouse hovering certain elements

6bf32a4

tyn1998 added 3 commits September 16, 2022 09:20

Merge branch 'master' into feat/add-more-data

df6a49e

fix: tooltip won't show after starring

00d4310

feat: embeded view for star and fork event number

2766d01

wj23027 and others added 4 commits October 3, 2022 13:22

fix: perceptor components cannot be disabled (hypertrons#464)

e715c65

refactor: remove antv related codes (hypertrons#462)

432cd6c

* refactor: remove antv * refactor: remove all `graphType` or `GraphType` from codebase Co-authored-by: Lam Tang <tangyenan@gmail.com>

fix: use query to fiter events of Echarts (hypertrons#466)

dce0fed

feat: add line series

c4ac0c8

tyn1998 force-pushed the feat/add-more-data branch from fac0f04 to c4ac0c8 Compare October 3, 2022 05:26

tyn1998 mentioned this pull request Oct 3, 2022

[Proposal]Update a OpenDigger Dashboard X-lab2017/open-digger#986

Closed

tyn1998 added 4 commits October 3, 2022 17:57

style: change line color

1399a43

refactor: rename files

6edb1ed

chore: enable tooltip axis trigger

91470f2

feat: repo detail issue view

30f24f9

feat: embeded view for PR details

aadbb8f

tyn1998 added 3 commits October 4, 2022 14:57

style: a considerate tooltip formatter

79e31fd

chore: runsWhen([isRepo]) -> runsWhen([isPublicRepo])

52a9635

feat: skeleton of header labels

467a8e9

tyn1998 added 2 commits October 5, 2022 00:24

fix: an awkward bug related to date comparing

b562b0b

feat: finish repo header labels

cf61bd4

tyn1998 changed the title ~~WIP: feat: show more data (in an embeded way)~~ feat: show more data (in an embeded way) Oct 4, 2022

tyn1998 marked this pull request as ready for review October 4, 2022 17:07

wxharry and others added 2 commits October 5, 2022 22:06

chore: modify chart titles and legends

0587f8c

Merge pull request #1 from wxharry/chore/charts-name

9c7f6a8

chore: modify chart titles and legends

wxharry approved these changes Oct 6, 2022

View reviewed changes

tyn1998 commented Oct 6, 2022

View reviewed changes

menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Oct 6, 2022

menbotics bot merged commit 32edf7a into hypertrons:master Oct 6, 2022

tyn1998 mentioned this pull request Nov 6, 2022

fix: repoLabel is not recognized right #505

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: show more data (in an embeded way) #455

feat: show more data (in an embeded way) #455

tyn1998 commented Sep 13, 2022 •

edited

Loading

tyn1998 commented Sep 13, 2022

tyn1998 commented Sep 17, 2022

tyn1998 commented Sep 17, 2022 •

edited

Loading

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

tyn1998 commented Sep 17, 2022 •

edited

Loading

frank-zsy commented Sep 17, 2022

tyn1998 commented Oct 1, 2022 •

edited

Loading

frank-zsy commented Oct 1, 2022

tyn1998 commented Oct 1, 2022

frank-zsy commented Oct 1, 2022

tyn1998 commented Oct 3, 2022

tyn1998 commented Oct 3, 2022

tyn1998 commented Oct 3, 2022

tyn1998 commented Oct 3, 2022 •

edited

Loading

tyn1998 commented Oct 4, 2022

tyn1998 commented Oct 4, 2022

wxharry commented Oct 4, 2022

tyn1998 commented Oct 5, 2022 •

edited

Loading

wxharry commented Oct 5, 2022

wxharry commented Oct 5, 2022

tyn1998 commented Oct 6, 2022

wxharry left a comment

tyn1998 left a comment

wxharry commented Oct 6, 2022

feat: show more data (in an embeded way) #455

feat: show more data (in an embeded way) #455

Conversation

tyn1998 commented Sep 13, 2022 • edited Loading

Brief Information

Details

Checklist

Others

tyn1998 commented Sep 13, 2022

tyn1998 commented Sep 17, 2022

tyn1998 commented Sep 17, 2022 • edited Loading

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

frank-zsy commented Sep 17, 2022

tyn1998 commented Sep 17, 2022 • edited Loading

frank-zsy commented Sep 17, 2022

tyn1998 commented Oct 1, 2022 • edited Loading

frank-zsy commented Oct 1, 2022

tyn1998 commented Oct 1, 2022

frank-zsy commented Oct 1, 2022

tyn1998 commented Oct 3, 2022

tyn1998 commented Oct 3, 2022

tyn1998 commented Oct 3, 2022

tyn1998 commented Oct 3, 2022 • edited Loading

tyn1998 commented Oct 4, 2022

tyn1998 commented Oct 4, 2022

wxharry commented Oct 4, 2022

tyn1998 commented Oct 5, 2022 • edited Loading

wxharry commented Oct 5, 2022

wxharry commented Oct 5, 2022

tyn1998 commented Oct 6, 2022

wxharry left a comment

Choose a reason for hiding this comment

tyn1998 left a comment

Choose a reason for hiding this comment

wxharry commented Oct 6, 2022

tyn1998 commented Sep 13, 2022 •

edited

Loading

tyn1998 commented Sep 17, 2022 •

edited

Loading

tyn1998 commented Sep 17, 2022 •

edited

Loading

tyn1998 commented Oct 1, 2022 •

edited

Loading

tyn1998 commented Oct 3, 2022 •

edited

Loading

tyn1998 commented Oct 5, 2022 •

edited

Loading