Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DeveloperActORTrend -> developer-activity-openrank-trends #596

Merged
merged 8 commits into from
Mar 5, 2023

Conversation

l1tok
Copy link
Collaborator

@l1tok l1tok commented Mar 3, 2023

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

  1. I refactored graph of developer-activity-openrank-trends based on new mechanism mentioned in refactor: introduce new feature loading mechanism #548.
  2. I deleted the related useless code based on old mechanism.

Checklist

Others

@menbotics menbotics bot added the kind/enhancement Category issues or prs related to enhancement. label Mar 3, 2023
Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lhbvvvvv, you did a good job, thank you so much!

The refactored developer-activity-openrank-trands works well in all aspects, while there is room for code improvement. So I pushed several small commits to improve the code and you can easily find what changes I made by reading the commit messages and diffs.

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Mar 5, 2023
@tyn1998 tyn1998 merged commit 85fa29b into hypertrons:v1.9.0 Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Category issues or prs related to enhancement. pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants