Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the network will crash if no edge provided #607

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

wj23027
Copy link
Collaborator

@wj23027 wj23027 commented Mar 14, 2023

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related issues (all available keywords):

Details

Added the judgment of whether ths edges is empty.
Now network chart works well when edges are empty.

image

Checklist

Others

@CLAassistant
Copy link

CLAassistant commented Mar 14, 2023

CLA assistant check
All committers have signed the CLA.

@wj23027 wj23027 changed the title Fix/no edge fix: the network will crash if no edge provided Mar 14, 2023
@menbotics menbotics bot added the kind/bug Category issues or prs related to bug. label Mar 14, 2023
@andyhuang18
Copy link
Collaborator

I met this problem before. Need to rebase your commit information~

@wj23027
Copy link
Collaborator Author

wj23027 commented Mar 14, 2023

I met this problem before. Need to rebase your commit information~

Thanks for the tips!

Copy link
Member

@tyn1998 tyn1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

/approve

@menbotics menbotics bot added the pull/approved If a pull is approved, it will be automatically merged label Mar 14, 2023
@menbotics menbotics bot merged commit 86c92c4 into hypertrons:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Category issues or prs related to bug. pull/approved If a pull is approved, it will be automatically merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] the network will crash if no edge provided
4 participants