Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo homepage latest commit hovercard openrank display #849

Merged
merged 8 commits into from
Aug 23, 2024

Conversation

Tenth-crew
Copy link
Collaborator

Brief Information

This pull request is in the type of (more info about types):

  • build
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • test

Related pr : #846

  • keyword #xxx

Details

Checklist

Others

Still don't know why the hovercard functionality is sometimes introduced twice

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Aug 15, 2024

iShot_2024-08-15_14.07.39.mp4

The current code logic is to attach the listener to the appropriate element during initialization. Openrank does not appear to be added to elements that appear during subsequent dynamic loads.

@Tenth-crew
Copy link
Collaborator Author

In this update, I added monitoring for dynamically loaded elements and prevented multiple additions of openrank information, because I encountered the phenomenon of openrank being added multiple times during my own testing. Now even if developer-hovercard-info is loaded twice, openrank will only be added once. In my personal testing, it works normally in opendigger, hypercrx and openai repositories.(The demo video is too large to fit

@Tenth-crew
Copy link
Collaborator Author

Now you can get the latest month's openrank instead of the latest openrank data. In addition, the problem that the openrank is added twice due to the avatar and ID being quickly swiped on the warehouse homepage has not been solved yet, but I personally think that this situation rarely occurs in normal use. This PR should be merged

@wangyantong2000
Copy link
Collaborator

wangyantong2000 commented Aug 15, 2024

iShot_2024-08-15_19.16.41.mp4

We think it's still necessary to complete it thoroughly before merging, otherwise it's not easy to manage multiple PRs for the same problem.

@Tenth-crew
Copy link
Collaborator Author

Yantong, you are my god, it really worked. I tried other time limits and found that 600ms is a good time setting. You are the key person to solve the problem!

@wangyantong2000
Copy link
Collaborator

Hi, is the PR ready? If this PR is ready, you can click ready for review. And others can test it and leave feedback.

@Tenth-crew Tenth-crew marked this pull request as ready for review August 23, 2024 09:40
@Tenth-crew
Copy link
Collaborator Author

yeah it ready for review

@HalloMelon
Copy link
Collaborator

HalloMelon commented Aug 23, 2024

I also tested it and found no problems.

Clipchamp.mp4
Clipchamp.1.mp4

@wangyantong2000
Copy link
Collaborator

I also tested it and found no problems.

Clipchamp.mp4
Clipchamp.1.mp4

Good feedback, very detailed.

@wangyantong2000 wangyantong2000 merged commit cda73a1 into hypertrons:master Aug 23, 2024
2 checks passed
@HalloMelon HalloMelon modified the milestones: 1.9.6, 1.9.8 Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants