-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: repo homepage latest commit hovercard openrank display #849
Conversation
iShot_2024-08-15_14.07.39.mp4The current code logic is to attach the listener to the appropriate element during initialization. Openrank does not appear to be added to elements that appear during subsequent dynamic loads. |
In this update, I added monitoring for dynamically loaded elements and prevented multiple additions of openrank information, because I encountered the phenomenon of openrank being added multiple times during my own testing. Now even if |
Now you can get the latest month's openrank instead of the latest openrank data. In addition, the problem that the openrank is added twice due to the avatar and ID being quickly swiped on the warehouse homepage has not been solved yet, but I personally think that this situation rarely occurs in normal use. This PR should be merged |
iShot_2024-08-15_19.16.41.mp4We think it's still necessary to complete it thoroughly before merging, otherwise it's not easy to manage multiple PRs for the same problem. |
Yantong, you are my god, it really worked. I tried other time limits and found that 600ms is a good time setting. You are the key person to solve the problem! |
Hi, is the PR ready? If this PR is ready, you can click |
yeah it ready for review |
I also tested it and found no problems. Clipchamp.mp4Clipchamp.1.mp4 |
Good feedback, very detailed. |
Brief Information
This pull request is in the type of (more info about types):
Related pr : #846
Details
Checklist
Others
Still don't know why the hovercard functionality is sometimes introduced twice