feat: improve side label UI #886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great, what will this be like for https://github.com/ray-project/ray ? |
FYI,
|
|
Sorry, what I mean is actually https://github.com/langchain-ai/langchain , because this repo does not have any GitHub tags. To append labels after GitHub tags, we should careful about the repos without any tags. |
frank-zsy
reviewed
Oct 9, 2024
src/pages/ContentScripts/features/repo-sidebar-labels/OpenDiggerLabel.tsx
Outdated
Show resolved
Hide resolved
|
I didn't consider that scenario. I will do a quick fix on this issue. |
|
Now it should work in repos without any tag :) |
|
@wangyantong2000 Could you have a look on this. |
OK |
src/pages/ContentScripts/features/repo-sidebar-labels/index.tsx
Outdated
Show resolved
Hide resolved
|
I tried several repositories and the previous issues were resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
2024-10-08.22.33.31.mov
Checklist
Others