-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: external url injection problem #888
Merged
wangyantong2000
merged 8 commits into
hypertrons:master
from
Xsy41:fix/external-url-injection-problem
Oct 19, 2024
Merged
fix: external url injection problem #888
wangyantong2000
merged 8 commits into
hypertrons:master
from
Xsy41:fix/external-url-injection-problem
Oct 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-zsy
reviewed
Oct 18, 2024
Xsy41
force-pushed
the
fix/external-url-injection-problem
branch
from
October 18, 2024 05:34
d0fadda
to
30c9088
Compare
If we can directly pack the image into the extension and use them in local env, that should be better than base64 encoding. Because usually base64 encoding will be a little bit larger than image format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of (more info about types):
Related issues (all available keywords):
Details
Convert openDiggerLogo and osGraphLogo to Base64 encoding.
Checklist
Others