Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

Bundling using nativescript-dev-webpack fails #49

Closed
rezonjov opened this issue Jun 14, 2017 · 5 comments
Closed

Bundling using nativescript-dev-webpack fails #49

rezonjov opened this issue Jun 14, 2017 · 5 comments

Comments

@rezonjov
Copy link

Hey, the plugin will fail when bundled using webpack.

The fix is to set "noEmitHelpers" to true at the tsconfig.json as mentioned here https://github.com/NativeScript/nativescript-dev-webpack/issues/70#issuecomment-279085077

So far it's working fine for me.

in case you need my environment:

  • node: 6.11
  • nativescript version: 2.3.2
  • nativescript-dev-webpack: 0.6.3
@hypery2k
Copy link
Owner

ok, will put it to the docs.

Thanks for the hint

hypery2k added a commit that referenced this issue Jun 19, 2017
@hypery2k hypery2k closed this as completed Jul 5, 2017
@msgitter
Copy link

msgitter commented Oct 13, 2017

Thank you for sharing this plugin.

The fix has to be applied to tsconfig.json of this plugin "nativescript-urlhandler", not to the one in the app project. So the hint in your docs sadly doesn't help.

That is why plugin authors need to configure their compiler NOT to emit helpers.

See for details: https://docs.nativescript.org/best-practices/bundling-with-webpack#emitting-helper-functions-in-typescript-plugins

@hypery2k
Can you release a new version of the plugin with the flag "noEmitHelpers": true set in tsconfig.json ?

hypery2k added a commit that referenced this issue Oct 15, 2017
@msgitter
Copy link

Thx for the quick fix.
When have you planned to release a new version containing this fix?

@hypery2k
Copy link
Owner

Not yet, having issues with my ci build

@hypery2k
Copy link
Owner

you can give nativescript-urlhandler@1.2.1-develop-91 a try

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants