Use NIO helpers in FileUtils for copy/move/rename #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OS will be perfectly capable of doing this, no need to read and write the individual bytes.
Move and rename now follow the same flow, no need to differentiate anymore. Deprecate `renameTo` and replace all of its occurrences with the equivalent `moveTo`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy was implemented through InputStream/OutputStream. The OS will be perfectly capable of doing this, no need to read and write the individual bytes. Use NIO's
Files.copyto perform the copy instead.Rename and move had two separate implementations without a compelling difference (apart from
renameTobeing unable to move across filesystem boundaries). Unify the two implementations and use the NIO'sFiles.moveto move the file atomically, or if that fails, non-atomically.