Remove Logger.OSThread-based PID logging that was always disabled #1016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneBab
reviewed
Dec 1, 2024
bertm
force-pushed
the
remove-osthread-pid-logging
branch
from
b7749c4 to
d87890a
Compare
The PID logging is always disabled and there is no API for enabling it. Remove the entire implementation and all the calls to its logPID method, but keep the interface for plugin compatibility.
bertm
force-pushed
the
remove-osthread-pid-logging
branch
from
d87890a to
59f0b6c
Compare
ArneBab
approved these changes
Dec 1, 2024
|
merged — thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PID logging is always disabled and there is no API for enabling it. Remove the entire class and all the calls to its logPID method.