Remove obsolete methods from Logger that are deprecated since 10+ years #1020
Conversation
LogLevel enum based log levels are preferred over int-based priorities since 2010. Remove the obsolete int-based methods, the int priority constants and their int-to-enum conversion method.
| public static final int NORMAL = LogLevel.NORMAL.ordinal(); | ||
|
|
||
| @Deprecated | ||
| public static final int MINOR = LogLevel.MINOR.ordinal(); |
There was a problem hiding this comment.
These are used from plugins (I see them in Thingamablog, Spider, and SCGIPublisher). I do not think we can get rid of them earlier than the next decade, except if we manage to take up maintenance for all our plugins again.
There was a problem hiding this comment.
Yeah, we're getting to a point where fred can evolve less and less because of unmaintained plugin compatibility.
Until we have a solution for that (like introducing a shim that provides compatibility for legacy plugins), we'll have to live with that. Closing this PR.
There was a problem hiding this comment.
Yes, that’s a reality we have to live with.
The steps to move forward would be to first create an actual defined plugin API (which does not expose the full node) and when there are plugins using it and it’s proven itself to be sufficiently powerful, analyze all known plugins that do not use the new API which parts of fred they use. Then annotate all those places as @Published(plugins=["...", "..."]) or such to track when plugin updates enable removing those limitations.
I’m pretty sure Bombe already has ideas for such an API.
|
Plugins need to be updated first. Unless we introduce a legacy shim mechanism, this will never get to a state where it can be merged. |
LogLevel enum based log levels are preferred over int-based priorities since 2010. Remove the obsolete int-based methods, the int priority constants and their int-to-enum conversion method.