Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.11 #996

Merged
merged 2 commits into from
Nov 30, 2024
Merged

Conversation

ArneBab
Copy link
Contributor

@ArneBab ArneBab commented Nov 12, 2024

simply via ./gradlew wrapper --gradle-version 8.11

No other changes.

simply via ./gradlew wrapper --gradle-version 8.11

No other changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checksum for this file does not match https://downloads.gradle.org/distributions/gradle-8.11-wrapper.jar.sha256 - it does match the 8.9 version though. Can you update the wrapper to 8.11?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated — thank you for the catch! That is ignored by .gitignore so I had to git add -f it and I had missed that.

@bertm bertm mentioned this pull request Nov 17, 2024
It’s ignored via .gitignore so must be force-added manually.
@ArneBab
Copy link
Contributor Author

ArneBab commented Nov 29, 2024

@bertm is this OK to merge?

Copy link
Contributor

@bertm bertm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the checksums do now match as expected 👍

@ArneBab ArneBab merged commit f677d92 into hyphanet:next Nov 30, 2024
1 check passed
@ArneBab
Copy link
Contributor Author

ArneBab commented Nov 30, 2024

Merged — thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants