Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the explicit dependency libexpat #435

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Remove the explicit dependency libexpat #435

merged 1 commit into from
Dec 5, 2024

Conversation

marcospri
Copy link
Member

@marcospri marcospri commented Dec 5, 2024

This is causing:

ERROR: unable to select packages:
libexpat-2.5.0-r2:

breaks: world[libexpat=2.6.3-r0]
satisfies: fontconfig-2.14.2-r4[so:libexpat.so.1]

The dependency was added a while back in:

#369 as it seemed to be missing

from the docker image but it's not a problem anymore.

More info also on:

Testing

  • We can the the image does build now:

docker compose build

successful on this branch, fails on main.

  • While the c library are not explicit installed on the image the python one is working:
docker exec -it report-metabase-1 python
Python 3.11.10 (main, Nov 12 2024, 02:18:01) [GCC 13.2.1 20231014] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyexpat

This is causing:

ERROR: unable to select packages:
  libexpat-2.5.0-r2:

  breaks: world[libexpat=2.6.3-r0]
  satisfies: fontconfig-2.14.2-r4[so:libexpat.so.1]

The dependency was added a while back in:

#369 as it seemed to be missing

from the docker image but it's not a problem anymore.
Copy link
Member

@robertknight robertknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (assuming the Docker image builds locally, as CI doesn't check before merging!)

@marcospri marcospri merged commit ea0d476 into main Dec 5, 2024
1 check passed
@marcospri marcospri deleted the removelibexpact branch December 5, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants