Refactor MGR coarse level matrix computation #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| AP = hypre_ParCSRMatMat(A, P); | ||
| RAP = hypre_ParCSRMatMat(R, AP); | ||
| hypre_CSRMatrixReorder(hypre_ParCSRMatrixDiag(RAP)); |
There was a problem hiding this comment.
Remind me why we are reordering here?
There was a problem hiding this comment.
This is from some time ago and I'm not 100% sure, but I believe it's because hypre_ParCSRMatMat doesn't guarantee that the diagonal entry goes first. So the reorder is to guarantee that. @liruipeng is this correct?
| #include <math.h> | ||
|
|
||
| /*-------------------------------------------------------------------- | ||
| * hypre_IntSequence |
There was a problem hiding this comment.
Can you add a description of what this function is doing?
|
|
||
| /* Destroy temporary variables */ | ||
| hypre_ParCSRMatrixDestroy(A_FC), A_FC = NULL; | ||
| hypre_ParCSRMatrixDestroy(A_CF), A_CF = NULL; | ||
| hypre_ParCSRMatrixDestroy(A_CC), A_CF = NULL; | ||
| hypre_ParCSRMatrixDestroy(A_CC), A_CC = NULL; |
| @@ -617,7 +612,7 @@ hypre_MGRSetup( void *mgr_vdata, | |||
| /* Allocate memory for level structure */ | |||
| if (A_array == NULL) | |||
| { | |||
| A_array = hypre_CTAlloc(hypre_ParCSRMatrix*, max_num_coarse_levels, HYPRE_MEMORY_HOST); | |||
| A_array = hypre_CTAlloc(hypre_ParCSRMatrix*, max_num_coarse_levels + 1, HYPRE_MEMORY_HOST); | |||
There was a problem hiding this comment.
Still wrapping my head around this one vs using the RAP_ptr, but it is not a big deal.
There was a problem hiding this comment.
This saves me some lines of code for computing MGR statistics in par_mgr_stats.c
oseikuffuor1
approved these changes
Jun 26, 2024
rfalgout
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main changes are:
hypre_MGRSetupimplementationHYPRE_MGRSetNonGalerkinMaxElmtsto control truncation in MGR's non-galerkin optionmax_elmts == 0(no truncation)par_mgr_rap.cfor coarse level matrix computation routinesAdditional changes that follow up:
hypre_CSRMatrixTruncateDiagto truncate a matrix to its diagonalutilities/stl_ops.cfor STL-like operations valid for host and device.