Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken workspace rules #6874

Closed
diniamo opened this issue Jul 13, 2024 · 3 comments · Fixed by #6878
Closed

Broken workspace rules #6874

diniamo opened this issue Jul 13, 2024 · 3 comments · Fixed by #6878
Labels
bug Something isn't working

Comments

@diniamo
Copy link
Contributor

diniamo commented Jul 13, 2024

Regression?

Yes

System Info and Version

The last working commit is b03f41e, meaning a443902 broke it.

Description

I have these 2 workspace rules in my config:

workspace=w[v1] s[false], gapsin:0, gapsout:0, border:false, shadow:false, rounding:false, decorate:false
workspace=f[1], gapsin:0, gapsout:0, border:false, shadow:false, rounding:false, decorate:false

And I noticed 2 issues:

  1. After opening 2 windows in a workspace, the first one retains the properties of the first workspace rule (it has no border and no rounding)
  2. When I have 2 windows, maximize one of them, only the gaps disappear, the border and rounding stay

How to reproduce

  1. Have the 2 workspace rules
  2. Follow the issues above

Crash reports, logs, images, videos

No response

@diniamo diniamo added the bug Something isn't working label Jul 13, 2024
@diniamo
Copy link
Contributor Author

diniamo commented Jul 13, 2024

@MightyPlaza - in case you care

@MightyPlaza
Copy link
Contributor

PR above should fix the regressions
however with your rules, floating the only window in a workspace will result in it not getting updated later on when another window gets open which is not a regression from that commit

@diniamo
Copy link
Contributor Author

diniamo commented Jul 14, 2024

I know, I already have another issue open for that from a while ago: #5467

Thanks for the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants