Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-* positions don't work in first monitor rule. #8529

Closed
GiantBlargg opened this issue Nov 19, 2024 · 2 comments
Closed

Auto-* positions don't work in first monitor rule. #8529

GiantBlargg opened this issue Nov 19, 2024 · 2 comments

Comments

@GiantBlargg
Copy link

GiantBlargg commented Nov 19, 2024

When the auto-* positions were added in #5670, it was decided that the first monitor should always be placed at 0x0, however the way it was implemented was that the first monitor rule should be set to auto-right, which would then place the first monitor at 0x0.

// If this is the first monitor rule needs to be on the right.
if (ARGS[2] == "auto-right" || ARGS[2] == "auto" || m_dMonitorRules.empty())
newrule.autoDir = eAutoDirs::DIR_AUTO_RIGHT;
else if (ARGS[2] == "auto-left")
newrule.autoDir = eAutoDirs::DIR_AUTO_LEFT;
else if (ARGS[2] == "auto-up")
newrule.autoDir = eAutoDirs::DIR_AUTO_UP;
else if (ARGS[2] == "auto-down")
newrule.autoDir = eAutoDirs::DIR_AUTO_DOWN;

This works alright assuming there's a 1:1 mapping between rules and monitors, but then you can't do this:

monitor=,preferred,auto-left,auto

Since this is the first (and only) rule it gets converted to auto-right, and then ALL monitors are arranged left-to-right, instead of right-to-left as requested.

@vaxerski
Copy link
Member

please follow the templates. Also make sure it's not #8518

@vaxerski vaxerski closed this as not planned Won't fix, can't repro, duplicate, stale Nov 19, 2024
@GiantBlargg
Copy link
Author

please follow the templates. Also make sure it's not #8518

I wasn't sure if this was right for the bug template as I felt I had already identified the issue, and I didn't want to share my system info as I don't believe it's system dependant.

This is not #8518. Here monitors are arranged in valid way just not in the way specified, as opposed to #8518 where monitors positions are invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants