IME: fix IME popup mouse inputs (again) #5417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungyoonc
reviewed
Apr 4, 2024
|
wtf is that IME lmao :D |
vaxerski
reviewed
Apr 4, 2024
`lastBoxLocal`'s size should be the actual popup's size instead of the cursor rectangle's size. Also, the rectangle position is now relative to the popup. (Actually fixes hyprwm#5255 imho.) One thing hyprwm#3922 missed was handling focus held by buttons. Let's hope I get it right this time.
It's my DIY handwriting recognition input method. :P |
lisuke
pushed a commit
to lisuke/Hyprland
that referenced
this pull request
Apr 15, 2024
`lastBoxLocal`'s size should be the actual popup's size instead of the cursor rectangle's size. Also, the rectangle position is now relative to the popup. (Actually fixes hyprwm#5255 imho.) One thing hyprwm#3922 missed was handling focus held by buttons. Let's hope I get it right this time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lastBoxLocal's size should be the actual popup's size instead of the cursor rectangle's size. Also, the rectangle position is now relative to the popup. (Actually fixes #5255 imho.)One thing #3922 missed was handling focus held by buttons. Let's hope I get it right this time.
There should be no regression in scaling and rendering, but I'm not entirely sure. cc @q234rty @sungyoonc
Before:
After:
