Fix duplication of "special:" in special workspace name #5729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Tokens for special workspaces have a duplicated
special:
string causing them to not spawn the windows properly.(i.e. a special workspace called
terminal
would show up asspecial:special:terminal
in the log)Fixes #5726's special workspace spawning problems
Special workspaces always have a name that either: defaults to
special
when not specified on creation or must havespecial:
prepended to their name when setting workspace rules.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I don't know where else thisgetConfigName()
function is called so I don't know if it breaks something else.Did a search through the project and it seems that KeybindManager.cpp is the only place where it is called as is. From my testing,
movetoworkspace
and its variants are all fine,togglespecialworkspace
is also fine andworkspace
does not apply to special workspaces.Is it ready for merging, or does it need work?
Ready for merging