Default unconfigured monitors to open to the right #5741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah clang-format needed |
eriedaberrie
force-pushed
the
auto-monitors-fixup
branch
2 times, most recently
from
2ffd21d to
83d4195
Compare
|
Whoops I accidentally pushed to the wrong branch just now. |
vaxerski
reviewed
Apr 25, 2024
eriedaberrie
force-pushed
the
auto-monitors-fixup
branch
from
83d4195 to
a977fcc
Compare
gulafaran
pushed a commit
to gulafaran/Hyprland
that referenced
this pull request
Apr 26, 2024
* config: default unconfigured monitors to open to the right * monitor: improve logging for auto positioning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This PR returns the functionality of making unconfigured monitors default to opening to the right (previously all the if statements fell through and they ended up opening up, the enum zero value). It also improves the logging for invalid auto directions. Finally, it makes the logging performed in arrangeMonitors actually accurate under the new directional auto system, instead of just stating the next available rightwards position even when the new monitor isn't being arranged to the right.
I also noticed that since the max monitor positions are being stored as ints, there was inconsistent use of decimals in the arrangeMonitor logging. Seeing as how monitor positions can only be integers values anyways, I opted to just remove all decimals in the logging.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
I'm not too sure if the logging changes are really in the scope of the PR but the inconsistencies were really bugging me and I didn't want to make a whole new PR to edit logging.
Is it ready for merging, or does it need work?