Window storage rework - part 1 #5762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
force-pushed
the
main
branch
2 times, most recently
from
7110a04 to
25aec3a
Compare
vaxerski
force-pushed
the
window-storage-rewrite-pt1
branch
from
96c0110 to
cf4b635
Compare
|
Just moving windows |
|
should be fixed |
|
yep 👍🏻 |
|
No crash, hypr just freeze and become irresponsible: How to repro:
UPD: No, It's unrelated to this PR, happens in upstream. |
|
There might be a memory leak..? |
|
hm, curious, as I've briefly tested at least the windows being removed from all vectors. Maybe it's vram? |
|
ah, yea, found |
|
fixed |
|
alright, thanks everyone, merging :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the storage of CWindow and its pointers memory-safe.
Breaks all plugins
part 2 will be moving events/Windows.cpp to members of CWindow
TODO:
cc @fufexan (meson/nix)
Leave a 👍 if everything is working well