Add option to change position of HyprError bar (#3241) #6111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Implements my own feature request: #3241.
Many people have their system bar up top. This means that when they have a config error, the error goes above the bar.
Depending on your set
error_limit, the errors might also cover up things like the top of your browser (which you might want to use to search for help), or the top of your terminal (which is where your prompt, and you'll use that to fix the error).This PR makes the position configurable:
debug:error_position = 0(default)debug:error_position = 1(or I guess it would work with any non-zero value).Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Tested in a nested debug instance. No problems found.
I would actually argue the default should be bottom, as I think more people have their bar up top than at the bottom. I assume the top is default for a reason?
Is it ready for merging, or does it need work?
Before merging this, I need to create a wiki PR to explain the new option. I'll create that after I get approval for this PR.