Fixes shrinking pseudotile windows. #6143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
approved these changes
May 18, 2024
The-Briel-Deal
added a commit
to The-Briel-Deal/Hyprland
that referenced
this pull request
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
#6051
There is a problem described here where a window shrinks to nothingness by floating and unfloating a pseudo-tiled window. The reason for this is for some reason if a window isn't tiled and the difference of real size and floating size is less than 10 px on x and y, then the window is shrunk to by 20 pixels in each direction?
I have no idea what the point of this shrinking is so I didn't modify any cases besides when a window is floating and pseudotiled. This fixes it however and shouldn't break anything else.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
This should be a small non-breaking change but I am curious why we would have this hardcoded shrink when going to floating?
Is it ready for merging, or does it need work?
Should be ready for merging.