[Scroll Wheel] discrete round away from zero + high res scrolling

[Agent00Ming]

Describe your PR, what does it fix/add?

Fixes #6278 and fixes #6299

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Fixed an unnoticed bug where setting input:scroll_factor too low would cause discrete axis events to round to zero.

Is it ready for merging, or does it need work?

Ready for merging but could use some more testing.

[darkiox]

Scrolling now works without issues using wireless mouse, can confirm that sensitivity is way too high hahah. Here are some logs, if they are useful for anything.

Thanks @Agent00Ming !!!
hyprland_wev_scroll.log

[Ciel-MC]

Works in Kitty, way too high, testing xwayland now

[Agent00Ming]

I think there's a better approach but this works as a band-aid fix for now. Applications have their own interpretation of discrete scrolling... the higher frequency of discrete scroll events works great in Firefox but not for terminal emulators and other apps... (the better approach being accumulating enough e.discreteDelta for a total of 120 and then send an event but that's also kinda shit)

Read up on the mess that is high-res scrolling here

[Agent00Ming]

@darkiox @Ciel-MC have a look at it now, it should be in a much better shape now. Blender still zooms in/out with crazy high sens because it doesn't support high resolution scrolling but kitty's scrolling seems much more reasonable now.

[Agent00Ming]

note that this should not affect low resolution scrolling (most common wired mice) with the exception of fixing an unnoticed bug where putting your input:scroll_factor too low would cause discrete scroll events to be rounded down to 0.

[darkiox]

Just tested, still feels a bit fast for my liking.
Tried changing input:scroll_factor and it did work on Wayland apps, but XWayland apps don't change the scroll speed. (Is that intended? Don't know for sure)

[Agent00Ming]

I'm afraid there isn't much we can do about xwayland clients, they take the scroll events at face value or something to that effect and don't support the wayland high resolution scrolling signals.

[darkiox]

I'm afraid there isn't much we can do about xwayland clients, they take the scroll events at face value or something to that effect and don't support the wayland high resolution scrolling signals.

Yeah I guess so, that's why there is worlds of difference between applications. Firefox for example works great (launched on X just to test) but kitty still flies lmao. Tried on Minecraft too (games running on Xwayland also suffer from this), and noticed it scrolls 6 steps each scroll of the wheel.
This is good enough for me to be honest, if you need more testing just lmk.

[vaxerski]

lgtm thanks!

[Sewer56]

The scroll speed in xwayland applications certainly is a hassle though.

There's a good number of applications (unfortunately proprietary) that are stuck in this state on my end, and not being able to scale it really is far from ideal. Think games, where switching a weapon is tied to scroll; or IDEs.

Anyway, I managed to run into here while wondering what might have changed to make these apps scroll so fast.

[tecknogyk]

Yeah, this is just unusable for me. Discord, Easy Effects, Nautilus, and Dolphin all scroll way too fast. Unless something changes Hyprland is just not something I can use anymore. Everything was fine before I updated.

[Ciel-MC]

Yeah, this is just unusable for me. Discord, Easy Effects, Nautilus, and Dolphin all scroll way too fast. Unless something changes Hyprland is just not something I can use anymore. Everything was fine before I updated.

All expect easy effects for me has Wayland support for which the scrolling is not broken, it’s currently only ruined on xwayland apps, try to make them launch under wayland