Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout: refine master layout new window handling #6479

Merged
merged 3 commits into from
Jun 15, 2024

Conversation

memchr
Copy link
Contributor

@memchr memchr commented Jun 13, 2024

Open window relative to active window

new_on_active:

  • none (default):
  • before: above of the focused window
  • after: below the focused window

If the focused window is the solo master window, or the new window replaces master, this option has no effect and new_on_top are respected.

Refine new window status control

BREAKING CHANGE: new_is_master removed in favour of new variable

new_status:

  • slave (default): new window open as slave
  • master: new window open as master
  • inherit: new window inherit status from active window, i.e. when the focused window is master, new window will become new master, otherwise new window are added to slaves

memchr added 3 commits June 13, 2024 11:14
`new_on_active`:
  - `none` (default):
  - `before`: above of the focused window
  - `after`: below the focused window

If the focused window is the solo master window, or the new window replaces master, this option has no effect and new_on_top are respected.

## Refine new window status control

**BREAKING CHANGE**: new_is_master removed in favour of new variable

`new_status`:
  - `slave` (default): new window open as slave
  - `master`: new window open as master
  - `inherit`: new window inherit status from active window, i.e. when the focused window is master, new window will become new master, otherwise new window are added to slaves
@memchr memchr marked this pull request as ready for review June 13, 2024 15:41
@memchr memchr changed the title Master_layout layout: refine master layout new window handling Jun 13, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, wiki mr needed

memchr added a commit to memchr/hyprland-wiki that referenced this pull request Jun 15, 2024
@vaxerski vaxerski merged commit 89f795d into hyprwm:main Jun 15, 2024
11 checks passed
vaxerski pushed a commit to hyprwm/hyprland-wiki that referenced this pull request Jun 15, 2024
@Ghosthree3
Copy link

Can this be updated, https://github.com/hyprwm/Hyprland/blob/main/example/hyprland.conf#L128
Default example config is now broken.

memchr added a commit to memchr/Hyprland that referenced this pull request Jun 16, 2024
hyprwm#6479 replace master:new_is_master with master:new_status
xymeng16 added a commit to xymeng16/dotfiles that referenced this pull request Jun 18, 2024
@hhhorb hhhorb mentioned this pull request Jul 1, 2024
sakshatshinde added a commit to sakshatshinde/nix-config that referenced this pull request Jul 1, 2024
taylorskalyo added a commit to taylorskalyo/pkgbuilds that referenced this pull request Jul 13, 2024
See also: hyprwm/Hyprland#6479

As far as I can tell, this breaking change was not documented in the
release notes :(
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants