Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pointer: use software rendering when monitor is mirrored #6587

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

lucasreis1
Copy link
Contributor

@lucasreis1 lucasreis1 commented Jun 18, 2024

Describe your PR, what does it fix/add?

Force software locks to monitors when they are being mirrored to another screen, so we can render the pointer properly in mirror monitors. Fixes #6455

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

I'm incrementing the lock counter for each new mirror. Maybe we could just increment/decrement it once if mirror list isn't/is empty, but I found it more concise this way.

Is it ready for merging, or does it need work?

Ready.

src/helpers/Monitor.cpp Outdated Show resolved Hide resolved
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, thanks!

@vaxerski vaxerski merged commit 20a465f into hyprwm:main Jun 19, 2024
11 checks passed
@lucasreis1 lucasreis1 deleted the pr/sw_cursor_on_mirror branch June 19, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mouse cursor visibility on mirrored screen
2 participants