Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: use hyprutils helper #6891

Merged
merged 4 commits into from
Jul 16, 2024
Merged

Config: use hyprutils helper #6891

merged 4 commits into from
Jul 16, 2024

Conversation

fufexan
Copy link
Member

@fufexan fufexan commented Jul 15, 2024

Describe your PR, what does it fix/add?

Uses the helpers added in hyprwm/hyprutils#8.
Follow-up PRs will also come to other hypr*apps near you.

Fixes #1040.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Tested all cases (any/all of the required variables missing, config missing completely).
Autogeneration also works.

Is it ready for merging, or does it need work?

Probably ready.

fufexan added 2 commits July 15, 2024 20:36
nix/overlays: remove xwayland overlay (merged upstream)
vaxerski
vaxerski previously approved these changes Jul 15, 2024
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool but has to wait for a new hyprutils release

@vaxerski
Copy link
Member

would you look at that https://github.com/hyprwm/hyprutils/releases/tag/v0.2.0

can you make this require 0.2

@fufexan
Copy link
Member Author

fufexan commented Jul 16, 2024

Done.

@vaxerski
Copy link
Member

why did you change 200 lines in the cmakelists file

@fufexan
Copy link
Member Author

fufexan commented Jul 16, 2024

Ah autoformatting on :wq. Should I revert?

@vaxerski
Copy link
Member

ye pls

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

サンキュー

@vaxerski vaxerski merged commit da956c8 into main Jul 16, 2024
20 checks passed
@fufexan fufexan deleted the config branch July 16, 2024 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global config file?
2 participants