Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate exclusiveEdge and don't set it as top by default #7006

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Jul 23, 2024

Describe your PR, what does it fix/add?

resolves #6987

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

anchor is defined as a enum bitfield so 0 is valid

<enum name="anchor" bitfield="true">
 <entry name="top" value="1" summary="the top edge of the anchor rectangle"/>
 <entry name="bottom" value="2" summary="the bottom edge of the anchor rectangle"/>
 <entry name="left" value="4" summary="the left edge of the anchor rectangle"/>
 <entry name="right" value="8" summary="the right edge of the anchor rectangle"/>
</enum>

Is it ready for merging, or does it need work?

yes

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks bae

@vaxerski vaxerski merged commit a5f58a3 into hyprwm:main Jul 23, 2024
11 checks passed
@ikalco ikalco deleted the fix_exclusiveEdge branch July 23, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants