add a destructor to CHyprOpenglImpl and avoid wl_container_of undefined behaviour #7101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tiv1 is being rewritten #7096 can you drop the changes there |
oh i see, sure |
fixed my love. |
|
want me to add the missing include to protocols/VirtualPointer.hpp to fix non precompiled header builds?
|
|
rebase on main |
to safely use wl_container_of with a class the class has to be no virtual functions, no inheritance, and uniform access control (e.g all public) work around this by putting this into a destroywrapper struct.
add a destructor and free the allocated memory and close the fd
rebased, now CI is happy :> |
vaxerski
approved these changes
Jul 29, 2024
vaxerski
pushed a commit
that referenced
this pull request
Jul 29, 2024
…ndefined behaviour (#7101) * protocols: avoid undefined behaviour in C macro to safely use wl_container_of with a class the class has to be no virtual functions, no inheritance, and uniform access control (e.g all public) work around this by putting this into a destroywrapper struct. * opengl: clean memory on destruction add a destructor and free the allocated memory and close the fd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add a destructor to CHyprOpenglImpl to free allocated memory/fd/etc to make asan more happy on destruction.
to safely use wl_container_of with a class the class has to be no virtual functions, no inheritance, and uniform access control (e.g all public)
work around this by putting this into a destroywrapper struct.