Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move globalshortcuts impl #7102

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Jul 29, 2024

Describe your PR, what does it fix/add?

also removed wayland-scanner dep

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

cmake and meson both compile for me
but someone should double check them to make sure I didn't do something wrong

also khotkeys is gone soo.... idk how to test

Is it ready for merging, or does it need work?

prob yes ^

@vaxerski
Copy link
Member

try mumble, that was my test case (it has a gs dbus MR)

@ikalco
Copy link
Contributor Author

ikalco commented Jul 29, 2024

im about to got somewhere but will test when i get back

@ikalco
Copy link
Contributor Author

ikalco commented Jul 30, 2024

that pr is broken on main too lol
somehow doesnt receive keypresses when setting shortcuts

edit:
i found this https://invent.kde.org/libraries/xdg-portal-test-kde
ill try it tmr

@ikalco ikalco force-pushed the move_globalshortcuts_impl branch from ed2522c to a282523 Compare July 30, 2024 21:23
@ikalco
Copy link
Contributor Author

ikalco commented Jul 30, 2024

just tested and fixed the impl, also rebased to main and fixed the conflict
should be gtg

for future testing use this with Ex. bind = SUPER,A,global,:AwesomeTrigger

  • compile and open xdg-portal-test-kde
  • hit configure shortcuts
  • use above keybinding (the :AwesomeTrigger is the trigger set by the app)
  • it should say activated to the right of that button until you let go, then it will say deactivated

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 3b9b534 into hyprwm:main Jul 30, 2024
10 checks passed
@ikalco ikalco deleted the move_globalshortcuts_impl branch July 31, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants