sessionLock: don't sendLocked when session lock has already been destoyed #7150
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Fixes the following crash that can happen when the lock object is destroyed, but the session is still locked:
Second commit (checking for
m_pSessionLock->lock->good()
) would fix it alone as well, but resettingm_pSessionLock
ondestroy
seems the right thing to do and i did not find any problems with it.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
When Hyprland is in the state where no lock screen client is present but the session is locked,
m_pSessionLock
will be anullptr
. The code already handles that by checkingm_pSessionLock
in the relevant places.Is it ready for merging, or does it need work?
Ready.