Fix syncFullscreen inconsistent with state when set by fullscreenState #7343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MightyPlaza iirc as the original MR author |
MightyPlaza
approved these changes
Aug 15, 2024
vaxerski
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
Changes in this PR ensure that
fullscreenStatealways setssyncFulscreento the correct value after dispatch regardless of the requestedinternalandclientstates.Starting with the state
1 0andsyncFullscreen = false:1 0, fullscreen state is set to0 0,syncFullscreenremains true1 -1, fullscreen state is set to0 0,syncFullscreenwas previously false-1 1, fullscreen state is set to1 1,syncFullscreenwas previously false2 2, fullscreen state is set to2 2,syncFullscreenwas previously falseIs there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Ready for merge