Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
These allow launching hyprland with a systemd service. They provide
graphical-session.target
which allows enabling services such as the ones for Waybar and Mako.The existing examples are more examples than actually being usable. For example the load ordering that waybar and mako expect for
graphical-session.target
is not upheld with them.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
They are rather flaky if modified. In particular:
Before=graphical-session.target
is removed then services part ofgraphical-session.target
will be launched before hyprland has time to update the user environment variables.--wait
is removed, the service will exit and immediately put you back into your display manager (e.g. regreet, sddm).Is it ready for merging, or does it need work?
Ready for merging as far as I'm concerned. I would even consider installing these by default on systemd systems.