Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more systemd examples #7409

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

JL2210
Copy link
Contributor

@JL2210 JL2210 commented Aug 19, 2024

Describe your PR, what does it fix/add?

These allow launching hyprland with a systemd service. They provide graphical-session.target which allows enabling services such as the ones for Waybar and Mako.

The existing examples are more examples than actually being usable. For example the load ordering that waybar and mako expect for graphical-session.target is not upheld with them.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

They are rather flaky if modified. In particular:

  • If Before=graphical-session.target is removed then services part of graphical-session.target will be launched before hyprland has time to update the user environment variables.
  • If --wait is removed, the service will exit and immediately put you back into your display manager (e.g. regreet, sddm).

Is it ready for merging, or does it need work?

Ready for merging as far as I'm concerned. I would even consider installing these by default on systemd systems.

These allow launching hyprland with a systemd service. They provide
graphical-session.target which allows enabling services such as the
ones for Waybar and Mako.
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@vaxerski vaxerski merged commit 01e3da4 into hyprwm:main Aug 19, 2024
10 checks passed
@vaxerski
Copy link
Member

MRs welcome

@vaxerski
Copy link
Member

"if at first you don't succeed, try, try again"

@JL2210
Copy link
Contributor Author

JL2210 commented Oct 23, 2024

/usr/share/wayland-sessions and /usr/lib/systemd/system for the desktop file and service, respectively

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants