Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

textinput: fix ime activation in some edge cases #7660

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

sungyoonc
Copy link
Contributor

Describe your PR, what does it fix/add?

Fix #7623

When telegram(QT using text input v3) closes to tray, it just destroys the focused surface without sending disable request. This resulted in text input v3 object's internal state not being resetted and when telegram tried to enable ti, hyprland thought it was already enabled.

neteast-cloud-music-gtk4 didn't create text input until it was visible and didn't receive enter event even though it was in focus.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Nothing

Is it ready for merging, or does it need work?

Ready

@vaxerski vaxerski merged commit 727f1b5 into hyprwm:main Sep 5, 2024
10 checks passed
@sungyoonc sungyoonc deleted the fix-ime-activation branch September 6, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text-input-v3 doesn't work in some cases
2 participants