-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added default button mapping for laptop multimedia keys for volume an… #7672
Conversation
I'm not against it, just pointing smth out, as I don't use any of these defaults you're proposing myself (then again I'm not the maintainer, soooo) |
You might be right that "not many" people will need this. More heads think clearer than one head. When I first installed Hyprland I got a bit stuck on this part. If you have a laptop then most likely you would be using volume and brightness keys, so I thought it would be nice to have this in the default config that people can just use without researching. Kind of like a jump starter for not-so-advanced users. But if the goal of the default config is to be as minimal as possible then this change is likely not a good fit. |
Linux Distributions with PipeWire by Default:
Linux Distributions with Optional PipeWire Support:
Rolling Release and Niche Distributions:
I am not a maintainer and it is not my decision, I only add some information |
Oh, I did not think that PipeWire was the questionable thing in my pull. If you are doing Wayland you are most likely doing PipeWire too. |
changes ok but need to be mirrored to exampleconfig in assets |
…d brightness into example config
Good now, boss? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea, thanks :)
Would you accept a PR for these too?
Playerctl is a command-line utility and library for controlling media players that implement the MPRIS D-Bus Interface Specification. Compatible players include audacious, cmus, mopidy, mpd, mpv, quod libet, rhythmbox, spotify, and vlc. |
👍 |
@RichAyotte I would recomment adding |
@JcBernack this isn't my PR, did you mean to tag @DarthChillash? |
@JcBernack it's merged already, but I actually use 100+ % on my laptop because T480 speakers are poor so 110-120 % helps a lot. If you guys think Hyprland defaults need to halt at 100% then I will make a new PR. |
@DarthChillash Interesting, but doesn't that cause clipping? In any case, as this is about a default config I would prefer the behavior to be in line with what most users would expect, which I would argue is a maximum of 100% volume. |
This adds sensible defaults for multimedia keys for volume and brightness. Ideally for laptop usage.
I tested this on my Thinkpad T480 and I am using this exact keys config.
It is ready to merge, in my opinion, unless you wish to comment these first so they are disabled by default.