Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Set cmake_minimum_required to version 3.30 #7709

Merged
merged 2 commits into from
Sep 10, 2024
Merged

build: Set cmake_minimum_required to version 3.30 #7709

merged 2 commits into from
Sep 10, 2024

Conversation

davc0n
Copy link
Contributor

@davc0n davc0n commented Sep 8, 2024

ref. #7707

@vaxerski
Copy link
Member

vaxerski commented Sep 8, 2024

@fufexan for nix ci

@fufexan
Copy link
Member

fufexan commented Sep 8, 2024

@vaxerski see the linked issue. There's nothing I can do until NixOS/nixpkgs#328256.

@vaxerski
Copy link
Member

vaxerski commented Sep 8, 2024

I have read that. Can't nix patch cmakelists until that is merged and keep the old patch (adding -std to the cc)?

@fufexan
Copy link
Member

fufexan commented Sep 10, 2024

Yeah I guess.

@github-actions github-actions bot added the Nix NixOS issue label Sep 10, 2024
fufexan
fufexan approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can be merged after CI passes.

@vaxerski vaxerski merged commit c67b257 into hyprwm:main Sep 10, 2024
11 checks passed
@davc0n davc0n deleted the cmake-3.30 branch October 7, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufexan fufexan fufexan approved these changes

Assignees
No one assigned
Labels
Nix NixOS issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davc0n @vaxerski @fufexan