Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nix: use meson #7774

Merged
merged 1 commit into from
Sep 13, 2024
Merged

nix: use meson #7774

merged 1 commit into from
Sep 13, 2024

Conversation

diniamo
Copy link
Contributor

@diniamo diniamo commented Sep 13, 2024

@github-actions github-actions bot added the Nix NixOS issue label Sep 13, 2024
@fufexan fufexan merged commit d505b33 into hyprwm:main Sep 13, 2024
11 checks passed
@diniamo diniamo deleted the nix-meson branch September 13, 2024 15:14
@JohnRTitor
Copy link
Contributor

I wonder why though, didn't we explicitly move from Meson to CMake? And I'll make a guess here that only one works here at any given time, presumably CMake.

@JohnRTitor
Copy link
Contributor

Oh I guess CMake building of Nix package is being phased out (#7778). If it solves issues like this #7508 (comment), I have no complaints.

@fufexan
Copy link
Member

fufexan commented Sep 13, 2024

There is a possibility, but the main reason we've moved back to meson is due to the faster builds (almost twice as fast).

@diniamo
Copy link
Contributor Author

diniamo commented Sep 13, 2024

Yes, as weird is at is, meson builds twice as fast.

@vaxerski
Copy link
Member

sounds wrong and doesn't seem to be the case on my end. CMake builds a bit faster.

Have you tried:

  • not using ninja for cmake
  • building w/o pch

@diniamo
Copy link
Contributor Author

diniamo commented Sep 13, 2024

@fufexan ?

@fufexan
Copy link
Member

fufexan commented Sep 13, 2024

2 hours and a bad graph later, I'm back with some rough results. Note that these builds were run on a Ryzen 5800U which is already better than GitHub's CI, but worse than many setups out there.

Hyprland build systems build times

Looks like we'll go back to using CMake.

fufexan added a commit that referenced this pull request Sep 13, 2024
No longer using ninja since CMake seems to build faster with the Make
backend (see #7774 (comment)).

Using mold for faster linking.

Using a stdenvAdapter for keeping debug info if `debug` is true.
fufexan added a commit that referenced this pull request Sep 13, 2024
No longer using ninja since CMake seems to build faster with the Make
backend (see #7774 (comment)).

Using mold for faster linking.

Using a stdenvAdapter for keeping debug info if `debug` is true.
fufexan added a commit that referenced this pull request Sep 13, 2024
No longer using ninja since CMake seems to build faster with the Make
backend (see #7774 (comment)).

Using mold for faster linking.

Using a stdenvAdapter for keeping debug info if `debug` is true.
fufexan added a commit that referenced this pull request Sep 22, 2024
No longer using ninja since CMake seems to build faster with the Make
backend (see #7774 (comment)).

Using mold for faster linking.

Using a stdenvAdapter for keeping debug info if `debug` is true.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Nix NixOS issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants