-
-
Notifications
You must be signed in to change notification settings - Fork 987
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hyprpm: target installed instead of running version #8634
Conversation
sooo... essentially then it builds for the installed version right? We also need a safeguard in |
Signed-off-by: rooot <hey@rooot.gay>
yeah.
i mean, the actual safeguard is in i suppose a notify would be neat though (like how i have it impld in i'll go and update upstream rq and then impl that |
Signed-off-by: rooot <hey@rooot.gay>
Signed-off-by: rooot <hey@rooot.gay>
somehow missed the other 2 snake_case vars i still had, oops |
I always squash dw |
Signed-off-by: rooot <hey@rooot.gay>
Signed-off-by: rooot <hey@rooot.gay>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rest lgtm
Signed-off-by: rooot <hey@rooot.gay>
fixed :) |
@RoootTheFox not just for me but the message pops up every hyprpm update |
yeah, oops, that's definitely not intended. i'll look into fixing that once i get time |
thanks |
Describe your PR, what does it fix/add?
After updating Hyprland,
hyprpm update
will still build plugins against the currently running version of Hyprland.This is a little annoying, because you first have to restart Hyprland and then run
hyprpm update
for your plugins to be built for the correct version.This PR makes
hyprpm
build against the installed version of Hyprland instead of the running version, and shows a popup notification if the running Hyprland version differs from the installed one after updating, telling users to restart Hyprland.Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
When I tested it on my setup (Arch) everything worked fine, so no I don't think so. Not sure how Nix handles stuff, but it should work there too I suppose.
I did change the signature of hyprpm's
getHyprlandVersion
func, but gave it a default value of true that corresponds to the original behavior.Is it ready for merging, or does it need work?
Should be ready for merging, although if you have any feedback (e.g. UX wise) go for it