snap: use the bit mask to check if snapping occurred #8659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
approved these changes
Dec 6, 2024
myQwil
added a commit
to myQwil/Hyprland
that referenced
this pull request
Dec 27, 2024
They seem like the same check, but a snap bit might not be turned on as expected if we grab a different corner after an edge has already been snapped.
vaxerski
pushed a commit
that referenced
this pull request
Dec 27, 2024
They seem like the same check, but a snap bit might not be turned on as expected if we grab a different corner after an edge has already been snapped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
This probably ends up being a slightly faster check. It's also more readable and more directly suited for this exact purpose.
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Nope
Is it ready for merging, or does it need work?
Ready for merging