Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove dead code #8748

Merged
merged 1 commit into from
Dec 17, 2024
Merged

remove dead code #8748

merged 1 commit into from
Dec 17, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Dec 17, 2024 •
edited
Loading

Describe your PR, what does it fix/add?

cleans up dead code forgotten to be removed in other commits (checked with blame)

found using cppcheck --enable=unusedFunction --check-level=exhaustive ./src

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

there are a lot more "unused" functions not removed in this pr, but

  • many are utilities probably used by plugins (asRGB, MBtoBytes, etc)
  • other utilities that could be used, but arent in rest of codebase (unsetEGL, drmModifierName, etc)
  • interesting amount look like regressions? or missing functionality (CSeatManager::sendTouchCancel, etc)

Is it ready for merging, or does it need work?

yes

@vaxerski vaxerski merged commit e2c78c0 into hyprwm:main Dec 17, 2024
11 checks passed
@ikalco ikalco deleted the remove_dead_code branch December 21, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
config core desktop events helpers layout managers protocols render
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikalco @vaxerski