Unbreak build on FreeBSD #8762
Merged
Unbreak build on FreeBSD #8762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaxerski
previously approved these changes
Dec 18, 2024
|
missing clang-format |
jbeich
force-pushed
the
environ
branch
3 times, most recently
from
73c403d to
ffdef06
Compare
jbeich
commented
Dec 18, 2024
BSD systems don't declare environ(7) in any header like POSIX suggests.
src/signal-safe.cpp:12:23: error: use of undeclared identifier 'environ'
12 | for (char** var = environ; *var != nullptr; var++) {
| ^
|
I fixed it for ya |
vaxerski
approved these changes
Dec 18, 2024
vaxerski
added a commit
that referenced
this pull request
Dec 19, 2024
* CrashReporter: restore explicit environ(7) after 8bbeee1 BSD systems don't declare environ(7) in any header like POSIX suggests. src/signal-safe.cpp:12:23: error: use of undeclared identifier 'environ' 12 | for (char** var = environ; *var != nullptr; var++) { | ^ * fix --------- Co-authored-by: Vaxry <vaxry@vaxry.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regressed by #8664. See #1708 for more details.