Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make static analysis more happy #8767

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Make static analysis more happy #8767

merged 4 commits into from
Dec 19, 2024

Conversation

ikalco
Copy link
Contributor

@ikalco ikalco commented Dec 19, 2024

Describe your PR, what does it fix/add?

  • moves single file functions to static
  • fixes a misuse of substr
  • default initializer for borderGradient, kinda nitpicky but improvement nonetheless
  • RASSERT uses std::print instead of printf

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

just opened my editor and fixed some of the red, might do more later

Is it ready for merging, or does it need work?

yes

vaxerski
vaxerski approved these changes Dec 19, 2024
View reviewed changes
Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naisu 👍

@vaxerski vaxerski merged commit 5b714f0 into hyprwm:main Dec 19, 2024
11 checks passed
@ikalco ikalco deleted the make_static_analysis_more_happy branch December 19, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaxerski vaxerski vaxerski approved these changes

Assignees
No one assigned
Labels
core debug desktop events helpers layout managers render xwayland
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikalco @vaxerski