Fix movefocus fallback for special workspaces #9040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Truenya
pushed a commit
to Truenya/Hyprland
that referenced
this pull request
Jan 13, 2025
littleblack111
pushed a commit
to littleblack111/Hyprland
that referenced
this pull request
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your PR, what does it fix/add?
movefocuson a special workspace does not behave as expected when focus fallback is required.Currently, if there's a window in the workspace beneath the special workspace, it will move focus to that and if there's no window beneath, it won't do anything. What it should be doing instead is just rotate focus on the special workspace only.
This happens because while calling
getWindowInDirection, the case of special workspace being present on current monitor is not handled. The fix is just to handle it.Fixes #9020
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
No
Is it ready for merging, or does it need work?
Ready to merge