layershell: check if layer is valid #9156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes compositor crash when client tried to create a layer surface with invalid layer argument
littleblack111
pushed a commit
to littleblack111/Hyprland
that referenced
this pull request
Jan 25, 2025
fixes compositor crash when client tried to create a layer surface with invalid layer argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes compositor crash when client tried to create a layer surface with invalid layer argument
Describe your PR, what does it fix/add?
When playing around with wayland clients I noticed that hyprland would crash when I try to pass an invalid layer param, turns out it was causing out of bounds array access in
Hyprland/src/desktop/LayerSurface.cpp
Line 37 in 57a3998
Basically copy pasted the check from
Hyprland/src/protocols/LayerShell.cpp
Line 147 in 57a3998
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
Nope
Is it ready for merging, or does it need work?
Ready