Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version to cmake install files #2

Merged
merged 1 commit into from
Apr 29, 2024
Merged

Conversation

cnt0
Copy link
Contributor

@cnt0 cnt0 commented Apr 29, 2024

So for example

find_package(hyprwayland-scanner 0.3.2 REQUIRED)

will be success if 0.3.3 is installed but failure in case of 0.3.1

@vaxerski vaxerski requested a review from fufexan April 29, 2024 15:10
Copy link
Member

@fufexan fufexan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@fufexan fufexan merged commit 672a965 into hyprwm:main Apr 29, 2024
1 check passed
@cnt0 cnt0 deleted the cmake-version branch April 30, 2024 05:36
@vaxerski
Copy link
Member

vaxerski commented May 1, 2024

This installs the files with 700 on my system, for some reason. It should be 755? Am I missing anythign?

@cnt0
Copy link
Contributor Author

cnt0 commented May 2, 2024

This installs the files with 700 on my system, for some reason. It should be 755? Am I missing anythign?

700 is weird. According to cmake documentation

Files installed by this form are by default given permissions OWNER_WRITE, OWNER_READ, GROUP_READ, and WORLD_READ if no PERMISSIONS argument is given

i.e. 644, which is exactly what I got on my system after

$ cmake -Bbuild
$ cmake --build build
$ cmake --install build --prefix install

755 for the executable, 644 for everything else.

@vaxerski
Copy link
Member

vaxerski commented May 2, 2024

I got 700... my fs is generally weird since a while back. When I cp executable files with sudo to /usr/bin I sometimes have to chmod them cuz they are 700 owned by root.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants